linux-kernel - Re: [PATCH] misc: eeprom: assignment outside the if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180803143612.121fba20@endymion>
Date:   Fri, 3 Aug 2018 14:36:12 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Parth Y Shah <sparth1292@...il.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org, bhumirks@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: eeprom: assignment outside the if statement

On Fri,  3 Aug 2018 14:50:43 +0530, Parth Y Shah wrote:
> Assignment of any variable should be kept outside the if statement

Actually there are exceptions to that rule, but this isn't one of them.

> Signed-off-by: Parth Y Shah <sparth1292@...il.com>
> ---
>  drivers/misc/eeprom/max6875.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max6875.c
> index 0e32709..fc0cf9a 100644
> --- a/drivers/misc/eeprom/max6875.c
> +++ b/drivers/misc/eeprom/max6875.c
> @@ -148,7 +148,8 @@ static int max6875_probe(struct i2c_client *client,
>  	if (client->addr & 1)
>  		return -ENODEV;
>  
> -	if (!(data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL)))
> +	data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL);
> +	if (!data)
>  		return -ENOMEM;
>  
>  	/* A fake client is created on the odd address */

Reviewed-by: Jean Delvare <jdelvare@...e.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support