linux-kernel - Re: [PATCH] lightnvm: pblk: remove unnecessary drive version check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <130c689a-723f-a32a-96e3-a7a59ff6b7b8@lightnvm.io>
Date:   Fri, 3 Aug 2018 14:39:50 +0200
From:   Matias Bjørling <mb@...htnvm.io>
To:     javier@...xlabs.com
Cc:     igor.j.konopko@...el.com, marcin.dziegielewski@...el.com,
        hans.holmberg@...xlabs.com, hlitz@...c.edu,
        youngtack.jin@...cuitblvd.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lightnvm: pblk: remove unnecessary drive version check

On 08/03/2018 02:18 PM, Javier Gonzalez wrote:
>> On 2 Aug 2018, at 22.58, Matias Bjørling <mb@...htnvm.io> wrote:
>>
>> The nvme driver checks for 1.2 and 2.0 compatibility. If an unsupported
>> version is reported, the device will not be initialized.
>>
>> Signed-off-by: Matias Bjørling <mb@...htnvm.io>
>> ---
>> drivers/lightnvm/pblk-init.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
>> index 537e98f2b24a..e9e2fedff387 100644
>> --- a/drivers/lightnvm/pblk-init.c
>> +++ b/drivers/lightnvm/pblk-init.c
>> @@ -1202,14 +1202,6 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
>> 	pblk->state = PBLK_STATE_RUNNING;
>> 	pblk->gc.gc_enabled = 0;
>>
>> -	if (!(geo->version == NVM_OCSSD_SPEC_12 ||
>> -					geo->version == NVM_OCSSD_SPEC_20)) {
>> -		pblk_err(pblk, "OCSSD version not supported (%u)\n",
>> -							geo->version);
>> -		kfree(pblk);
>> -		return ERR_PTR(-EINVAL);
>> -	}
>> -
>> 	if (geo->version == NVM_OCSSD_SPEC_12 && geo->dom & NVM_RSP_L2P) {
>> 		pblk_err(pblk, "host-side L2P table not supported. (%x)\n",
>> 							geo->dom);
>> --
>> 2.11.0
> 
> The same comment goes for this patch. pblk does support 2.0 and 1.2
> today, but it is not guaranteed it will support a new revision straight
> away. So I think that a check wither here or through the .capabilities I
> proposed on the other patch is necessary.
> 

Works for me. I'll send another patch that enables pblk target to tell 
which version it supports.