linux-kernel - Re: [PATCH 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes.

Open Source and information security mailing list archives

Date:   Fri, 3 Aug 2018 21:50:25 +0800
From:   Yixun Lan <yixun.lan@...il.com>
To:     Maxime Jourdan <maxi.jourdan@...adoo.fr>
Cc:     Kevin Hilman <khilman@...libre.com>, devicetree@...r.kernel.org,
        Neil Armstrong <narmstrong@...libre.com>,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes.

Hi Maxime

great job! thanks for contributing the patches..

On Thu, Aug 2, 2018 at 2:51 AM, Maxime Jourdan <maxi.jourdan@...adoo.fr> wrote:
> Wrap the canvas node in a syscon node.
>
> Signed-off-by: Maxime Jourdan <maxi.jourdan@...adoo.fr>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index b8dc4dbb391b..d104b9e111fb 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -423,6 +423,23 @@
>                         };
>                 };
>
> +               dmcbus: bus@...38000 {
> +                       compatible = "simple-bus";
> +                       reg = <0x0 0xc8838000 0x0 0x1000>;
> +                       #address-cells = <2>;
> +                       #size-cells = <2>;
> +                       ranges = <0x0 0x0 0x0 0xc8838000 0x0 0x1000>;
> +
> +                       sysctrl_DMC: system-controller@0 {
> +                               compatible = "amlogic,meson-gx-dmc-sysctrl", "syscon", "simple-mfd";

we'd like to drop 'meson-' prefix, so better using "amlogic,gx-dmc-sysctrl",
please take a look at the discussion here [1]

[1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@baylibre.com

> +                               reg = <0x0 0x0 0x0 0x1000>;
> +
> +                               canvas: canvas-provider@0 {
> +                                       compatible = "amlogic,meson-canvas";
ditto

> +                               };
> +                       };
> +               };
> +
>                 hiubus: bus@...3c000 {
>                         compatible = "simple-bus";
>                         reg = <0x0 0xc883c000 0x0 0x2000>;
> --
> 2.17.1
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives