linux-kernel - Re: [PATCH] riscv: remove unnecessary of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-3bfbca5d-24d1-4d39-a84b-d1b0ec6708aa@palmer-si-x1c4>
Date:   Thu, 02 Aug 2018 18:58:28 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...ive.com>
To:     robh@...nel.org
CC:     linux-kernel@...r.kernel.org, aou@...s.berkeley.edu,
        linux-riscv@...ts.infradead.org
Subject:     Re: [PATCH] riscv: remove unnecessary of_platform_populate call

On Mon, 09 Jul 2018 08:50:05 PDT (-0700), robh@...nel.org wrote:
> On Tue, Jun 19, 2018 at 3:41 PM Rob Herring <robh@...nel.org> wrote:
>>
>> The DT core will call of_platform_default_populate, so it is not
>> necessary for arch specific code to call it unless there are custom
>> match entries, auxdata or parent device. Neither of those apply here, so
>> remove the call.
>>
>> Cc: Palmer Dabbelt <palmer@...ive.com>
>> Cc: Albert Ou <aou@...s.berkeley.edu>
>> Cc: linux-riscv@...ts.infradead.org
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>>  arch/riscv/kernel/setup.c | 5 -----
>>  1 file changed, 5 deletions(-)
>
> Ping?

Sorry for not saying anything, I don't have a good scheme for automatically 
tracking patches as they flow through my tree and my inbox is a bit backed up.  
This landed as part of b19b9282093588e73401f9d4981310a8de975f7d.

Thanks for the fix!

>>
>> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
>> index ee44a48faf79..f0d2070866d4 100644
>> --- a/arch/riscv/kernel/setup.c
>> +++ b/arch/riscv/kernel/setup.c
>> @@ -220,8 +220,3 @@ void __init setup_arch(char **cmdline_p)
>>         riscv_fill_hwcap();
>>  }
>>
>> -static int __init riscv_device_init(void)
>> -{
>> -       return of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
>> -}
>> -subsys_initcall_sync(riscv_device_init);