linux-kernel - Re: [RESEND PATCH] resource: Merge resources on a node when hot-adding memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201808040130.Ve042Wls%fengguang.wu@intel.com>
Date:   Sat, 4 Aug 2018 01:25:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rashmica Gupta <rashmica.g@...il.com>
Cc:     kbuild-all@...org, toshi.kani@....com, tglx@...utronix.de,
        akpm@...ux-foundation.org, bp@...e.de, brijesh.singh@....com,
        thomas.lendacky@....com, jglisse@...hat.com,
        gregkh@...uxfoundation.org, baiyaowei@...s.chinamobile.com,
        dan.j.williams@...el.com, mhocko@...e.com, iamjoonsoo.kim@....com,
        vbabka@...e.cz, malat@...ian.org, pasha.tatashin@...cle.com,
        bhelgaas@...gle.com, osalvador@...hadventures.net,
        yasu.isimatu@...il.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Rashmica Gupta <rashmica.g@...il.com>
Subject: Re: [RESEND PATCH] resource: Merge resources on a node when
 hot-adding memory

Hi Rashmica,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc7]
[cannot apply to next-20180802]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rashmica-Gupta/resource-Merge-resources-on-a-node-when-hot-adding-memory/20180803-221205
config: x86_64-randconfig-s1-08032324 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   mm/memory_hotplug.c: In function 'add_memory':
>> mm/memory_hotplug.c:1191:3: error: implicit declaration of function 'release_mem_region_adjustable' [-Werror=implicit-function-declaration]
      release_mem_region_adjustable(&iomem_resource, start, size);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/release_mem_region_adjustable +1191 mm/memory_hotplug.c

  1179	
  1180	int __ref add_memory(int nid, u64 start, u64 size)
  1181	{
  1182		struct resource *res;
  1183		int ret;
  1184	
  1185		res = register_memory_resource(nid, start, size);
  1186		if (IS_ERR(res))
  1187			return PTR_ERR(res);
  1188	
  1189		ret = add_memory_resource(nid, start, size, memhp_auto_online);
  1190		if (ret < 0) {
> 1191			release_mem_region_adjustable(&iomem_resource, start, size);
  1192			kfree(res);
  1193		}
  1194		return ret;
  1195	}
  1196	EXPORT_SYMBOL_GPL(add_memory);
  1197	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30715 bytes)