linux-kernel - Re: [PATCH net-next] ppp: mppe: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180803.125513.1756655974530187845.davem@davemloft.net>
Date:   Fri, 03 Aug 2018 12:55:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     netdev@...r.kernel.org, paulus@...ba.org,
        linux-ppp@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] ppp: mppe: Remove VLA usage

From: Kees Cook <keescook@...omium.org>
Date: Fri, 3 Aug 2018 09:37:45 -0700

> In the quest to remove all stack VLA usage from the kernel[1], this
> removes the discouraged use of AHASH_REQUEST_ON_STACK (and associated
> VLA) by switching to shash directly and keeping the associated descriptor
> allocated with the regular state on the heap.
> 
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> ---
> Paul suggested this go via netdev directly:
> https://lkml.kernel.org/r/20180803031315.GA30807@fergus

Applied, thanks Kees.