linux-kernel - Re: [PATCH] pstore: set PSTORE_ZSTD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jJazh2UG9PVnt7JFHcCbMm9mFy2r1_BULkqUhmr5t6Mvg@mail.gmail.com>
Date:   Fri, 3 Aug 2018 19:05:30 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        LKML <linux-kernel@...r.kernel.org>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH] pstore: set PSTORE_ZSTD_COMPRESS to bool

On Fri, Aug 3, 2018 at 2:16 AM, Geliang Tang <geliangtang@...il.com> wrote:
> Fix build error:
>
>    fs/pstore/platform.o: In function `zbufsize_zstd':
>>> platform.c:(.text+0x172): undefined reference to `ZSTD_compressBound'
>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>

Thanks! I'll squash this into the original commit.

-Kees

> ---
>  fs/pstore/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
> index 63cf4813559a..503086f7f7c1 100644
> --- a/fs/pstore/Kconfig
> +++ b/fs/pstore/Kconfig
> @@ -51,7 +51,7 @@ config PSTORE_842_COMPRESS
>           This option enables 842 compression algorithm support.
>
>  config PSTORE_ZSTD_COMPRESS
> -       tristate "zstd compression"
> +       bool "zstd compression"
>         depends on PSTORE
>         select CRYPTO_ZSTD
>         help
> --
> 2.17.1
>



-- 
Kees Cook
Pixel Security