linux-kernel - Re: [PATCH] net: cisco: enic: Replace GFP_ATOMIC with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180804.130833.571423391959893455.davem@davemloft.net>
Date:   Sat, 04 Aug 2018 13:08:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baijiaju1990@...il.com
Cc:     benve@...co.com, _govind@....com, pkaustub@...co.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: cisco: enic: Replace GFP_ATOMIC with GFP_KERNEL

From: Jia-Ju Bai <baijiaju1990@...il.com>
Date: Sat,  4 Aug 2018 08:40:09 +0800

> vnic_dev_register(), vnic_rq_alloc_bufs() and vnic_wq_alloc_bufs() 
> are never called in atomic context.
> They call kzalloc() with GFP_ATOMIC, which is not necessary.
> GFP_ATOMIC can be replaced with GFP_KERNEL.
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied to net-next, thanks.