linux-kernel - Re: [PATCH v3 1/3] iio: adc: add support for mcp3911

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeDy=9o84K-PnASOMNXrNc9B1v9azWkx-wb4uLcomj_Vw@mail.gmail.com>
Date:   Sat, 4 Aug 2018 23:56:17 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Marcus Folkesson <marcus.folkesson@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Kent Gustavsson <kent@...oris.se>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] iio: adc: add support for mcp3911

On Sat, Aug 4, 2018 at 9:55 AM, Marcus Folkesson
<marcus.folkesson@...il.com> wrote:
> On Fri, Aug 03, 2018 at 11:09:22PM +0100, Jonathan Cameron wrote:
>> On Thu, 2 Aug 2018 22:52:00 +0300
>> Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>>
>> > On Thu, Aug 2, 2018 at 10:15 PM, Marcus Folkesson
>> > <marcus.folkesson@...il.com> wrote:
>> > > MCP3911 is a dual channel Analog Front End (AFE) containing two
>> > > synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
>> > >
>> > > Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
>> >
>> > > Signed-off-by: Kent Gustavsson <kent@...oris.se>
>> >
>> > What is this? Why it's here (presense and location in the message)?
>> To clarify... If Kent wrote the patch and you are simply acting
>> as gatekeeper / upstreamer you should set the mail to be from Kent
>> and put your own Signed-off after his to basically act as a submaintainer
>> certifying you believe his sign off and all that entails.

Yep. And here the ordering is incorrect, right?

>> If it is a bit of a joint effort then that's fine but for copyright
>> purposes there should be some indication of the split.
>
> First, thank you Andy for noticing.
>
> I actually intended to use Co-Developed-by (a pretty new tag)
> in combination with Signed-off-by.
> But the tag must have disappeared in some preparation stage..
>
> From Documentation/process/submitting-patches.rst ::
>
>         A Co-Developed-by: states that the patch was also created by another developer
>         along with the original author.  This is useful at times when multiple people
>         work on a single patch.  Note, this person also needs to have a Signed-off-by:
>         line in the patch as well.
>
> I will switch order and add the Co-Developed-by-tag.
> Is this correct?
>
> Co-Developed-by: Kent Gustavsson <kent@...oris.se>
> Signed-off-by: Kent Gustavsson <kent@...oris.se>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>

Yep, this looks good!

>> > > +       of_property_read_u32(of_node, "device-addr", &adc->dev_addr);

>> > Isn't what we called CS (chip select)?
>> Nope. We went around this in an earlier revision. It's an address transmitted
>> in the control byte to allow you to 'share' a chip select line between multiple
>> chips (crazy but true).

OK.

-- 
With Best Regards,
Andy Shevchenko