linux-kernel - Re: [PATCH] Staging: rtlwifi: base: fixed a brace coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1808040907480.2435@hadrien>
Date:   Sat, 4 Aug 2018 09:08:46 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Sohil Ladhani <supertakumi86@...il.com>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Kees Cook <keescook@...omium.org>,
        Julia Lawall <julia.lawall@...6.fr>,
        Nathan Chancellor <natechancellor@...il.com>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Arushi Singhal <arushisinghal19971997@...il.com>,
        "Frank A. Cancio Bello" <frank@...eralsoftwareinc.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtlwifi: base: fixed a brace coding style
 issue



On Sat, 4 Aug 2018, Sohil Ladhani wrote:

> Fixed a coding style issue

This seems to fix the header problem.  But it is a patch on the same code
at the same place doing the same thing as the previous message.  So you
should say [PATCH v2] in the subject line, and then below the --- explain
what has changed as compared to the previous submission.

julia

>
> Signed-off-by: Sohil Ladhani <supertakumi86@...il.com>
> ---
>  drivers/staging/rtlwifi/base.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index 094827c1879a..654aa4e068ba 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
> @@ -685,9 +685,8 @@ static void _rtl_query_protection_mode(struct ieee80211_hw *hw,
>  	}
>  }
>
> -u8 rtl_mrate_idx_to_arfr_id(
> -	struct ieee80211_hw *hw, u8 rate_index,
> -	enum wireless_mode wirelessmode)
> +u8 rtl_mrate_idx_to_arfr_id(struct ieee80211_hw *hw, u8 rate_index,
> +			    enum wireless_mode wirelessmode)
>  {
>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
>  	struct rtl_phy *rtlphy = &rtlpriv->phy;
> --
> 2.18.0
>
>