linux-kernel - Re: [PATCH] USB: Removing NULL check for pool since dma_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180805142709.GA11958@kroah.com>
Date:   Sun, 5 Aug 2018 16:27:09 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Salil Kapur <salilkapur93@...il.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: Removing NULL check for pool since dma_pool_destroy
 is safe

On Sat, Aug 04, 2018 at 12:10:22AM -0700, Salil Kapur wrote:
> Removing NULL check for pool since dma_pool_destroy is safe
> 
> Signed-off-by: Salil Kapur <salilkapur93@...il.com>
> ---
>  drivers/usb/core/buffer.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c
> index 77eef8acff94..f641342cdec0 100644
> --- a/drivers/usb/core/buffer.c
> +++ b/drivers/usb/core/buffer.c
> @@ -101,12 +101,8 @@ void hcd_buffer_destroy(struct usb_hcd *hcd)
>          return;
>  
>      for (i = 0; i < HCD_BUFFER_POOLS; i++) {
> -        struct dma_pool *pool = hcd->pool[i];
> -
> -        if (pool) {
> -            dma_pool_destroy(pool);
> -            hcd->pool[i] = NULL;
> -        }
> +        dma_pool_destroy(hcd->pool[i]);
> +        hcd->pool[i] = NULL;
>      }
>  }
>  
> -- 
> 2.14.4

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot