linux-kernel - Re: [PATCH 0/3] Remove uneeded variable "err"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9f07f02-38c0-7491-3b48-0dda20f60d13@suse.com>
Date:   Sun, 5 Aug 2018 22:14:29 +0300
From:   Nikolay Borisov <nborisov@...e.com>
To:     zhong jiang <zhongjiang@...wei.com>, clm@...com, jbacik@...com,
        dsterba@...e.com
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Remove uneeded variable "err"



On  5.08.2018 18:02, zhong jiang wrote:
> 
> zhong jiang (3):
>   fs/btrfs/disk-io: Remove unneeded variable "err"
>   fs/btrfs/extent-tree: remove redudant variable "err"
>   fs/btrfs/tree-log: remove the unneeded variable "err"
> 
>  fs/btrfs/disk-io.c     | 12 ++++--------
>  fs/btrfs/extent-tree.c |  6 ++----
>  fs/btrfs/tree-log.c    |  5 +----
>  fs/btrfs/tree-log.h    |  2 +-
>  4 files changed, 8 insertions(+), 17 deletions(-)
> 


NAK on the whole series on the basis of using a bulk commit message
which doesn't really describe the changes of each individual commit. If
you want those changes to eventually be merged resubmit the series with
individual reasoning for every commit.