linux-kernel - [tip:x86/urgent] x86/irqflags: Provide a declaration for native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 Aug 2018 13:33:49 -0700
From:   tip-bot for Nick Desaulniers <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mingo@...nel.org, jdelvare@...e.de, ndesaulniers@...gle.com,
        hpa@...or.com, tglx@...utronix.de, david.laight@...lab.com,
        linux-kernel@...r.kernel.org
Subject: [tip:x86/urgent] x86/irqflags: Provide a declaration for
 native_save_fl

Commit-ID:  208cbb32558907f68b3b2a081ca2337ac3744794
Gitweb:     https://git.kernel.org/tip/208cbb32558907f68b3b2a081ca2337ac3744794
Author:     Nick Desaulniers <ndesaulniers@...gle.com>
AuthorDate: Fri, 3 Aug 2018 10:05:50 -0700
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Sun, 5 Aug 2018 22:30:37 +0200

x86/irqflags: Provide a declaration for native_save_fl

It was reported that the commit d0a8d9378d16 is causing users of gcc < 4.9
to observe -Werror=missing-prototypes errors.

Indeed, it seems that:
extern inline unsigned long native_save_fl(void) { return 0; }

compiled with -Werror=missing-prototypes produces this warning in gcc <
4.9, but not gcc >= 4.9.

Fixes: d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline").
Reported-by: David Laight <david.laight@...lab.com>
Reported-by: Jean Delvare <jdelvare@...e.de>
Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: hpa@...or.com
Cc: jgross@...e.com
Cc: kstewart@...uxfoundation.org
Cc: gregkh@...uxfoundation.org
Cc: boris.ostrovsky@...cle.com
Cc: astrachan@...gle.com
Cc: mka@...omium.org
Cc: arnd@...db.de
Cc: tstellar@...hat.com
Cc: sedat.dilek@...il.com
Cc: David.Laight@...lab.com
Cc: stable@...r.kernel.org
Link: https://lkml.kernel.org/r/20180803170550.164688-1-ndesaulniers@google.com

---
 arch/x86/include/asm/irqflags.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index c4fc17220df9..c14f2a74b2be 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -13,6 +13,8 @@
  * Interrupt control:
  */

+/* Declaration required for gcc < 4.9 to prevent -Werror=missing-prototypes */
+extern inline unsigned long native_save_fl(void);
 extern inline unsigned long native_save_fl(void)
 {
 	unsigned long flags;