linux-kernel - Re: [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 05 Aug 2018 23:51:36 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Marc Zyngier <marc.zyngier@....com>
Cc:     dri-devel@...ts.freedesktop.org,
        Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg

Hi Marc,

Thank you for the patch.

On Sunday, 5 August 2018 20:28:57 EEST Marc Zyngier wrote:
> The Analogix DP bridge driver is pretty verbose, and outputs
> things like
> 
> [  619.414067] rockchip-dp ff970000.edp: Link Training Clock Recovery
> success [  619.429233] rockchip-dp ff970000.edp: Link Training success!
> 
> each time the display gets unblanked. While it is good to know
> that the device is behaving correctly, users already know that
> because they can see some video output.
> 
> Let's keep these messages for cases where we need to actually
> debug the driver (we have dynamic debug to enable them at runtime
> if need be), and let's keep the kernel quiet otherwise.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index
> 2bcbfadb6ac5..0d715a375ff9 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -554,7 +554,7 @@ static int analogix_dp_process_clock_recovery(struct
> analogix_dp_device *dp)
>  		if (retval < 0)
>  			return retval;
> 
> -		dev_info(dp->dev, "Link Training Clock Recovery success\n");
> +		dev_dbg(dp->dev, "Link Training Clock Recovery success\n");
>  		dp->link_train.lt_state = EQUALIZER_TRAINING;
>  	} else {
>  		for (lane = 0; lane < lane_count; lane++) {
> @@ -634,7 +634,7 @@ static int analogix_dp_process_equalizer_training(struct
> analogix_dp_device *dp)
>  		if (retval < 0)
>  			return retval;
> 
> -		dev_info(dp->dev, "Link Training success!\n");
> +		dev_dbg(dp->dev, "Link Training success!\n");
>  		analogix_dp_get_link_bandwidth(dp, &reg);
>  		dp->link_train.link_rate = reg;
>  		dev_dbg(dp->dev, "final bandwidth = %.2x\n",

-- 
Regards,

Laurent Pinchart