linux-kernel - Re: [PATCH] clocksource: ti-32k: Remove CLOCK_SOURCE_SUSPEND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180806081656.GN99251@atomide.com>
Date:   Mon, 6 Aug 2018 01:16:56 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Keerthy <j-keerthy@...com>
Cc:     daniel.lezcano@...aro.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        baolin.wang@...aro.org, d-gerlach@...com, grygorii.strashko@...com,
        t-kristo@...com
Subject: Re: [PATCH] clocksource: ti-32k: Remove CLOCK_SOURCE_SUSPEND_NONSTOP
 flag

Keerthy,

* Keerthy <j-keerthy@...com> [180802 06:39]:
> With the introduction of below commit:
> 
> commit 39232ed5a1793f67b11430c43ed8a9ed6e96c6eb
> 
> time: Introduce one suspend clocksource to compensate the suspend time
> 
> The suspend/resume fails on AM437x platforms as the source is not
> a non-stop while trying to compensate time using this.
>
> Hence remove the CLOCK_SOURCE_SUSPEND_NONSTOP flag.

The 32k timer only stops on am4, on omap3 to omap5 and dra7 it's always
on. So the NONSTOP flag should be removed only for am4.

Care to do an incremental patch clearing NONSTOP based on compatible
property?

Regards,

Tony

> Suggested-by: Grygorii Strashko <grygorii.strashko@...com>
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---
>  drivers/clocksource/timer-ti-32k.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
> index 880a861..7368e8e 100644
> --- a/drivers/clocksource/timer-ti-32k.c
> +++ b/drivers/clocksource/timer-ti-32k.c
> @@ -78,8 +78,7 @@ static u64 notrace ti_32k_read_cycles(struct clocksource *cs)
>  		.rating		= 250,
>  		.read		= ti_32k_read_cycles,
>  		.mask		= CLOCKSOURCE_MASK(32),
> -		.flags		= CLOCK_SOURCE_IS_CONTINUOUS |
> -				CLOCK_SOURCE_SUSPEND_NONSTOP,
> +		.flags		= CLOCK_SOURCE_IS_CONTINUOUS, 
>  	},
>  };
>  
> -- 
> 1.9.1
>