linux-kernel - Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMz4kuJMPc6bVZZbJif2cmx3Ea0xc1Bc4JYyEQjaskppGNddtA@mail.gmail.com>
Date:   Mon, 6 Aug 2018 16:31:54 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        rteysseyre@...il.com, Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

On 6 August 2018 at 16:06, Pavel Machek <pavel@....cz> wrote:
> On Mon 2018-08-06 15:33:12, Baolin Wang wrote:
>> Hi Pavel,
>>
>> On 6 August 2018 at 15:09, Pavel Machek <pavel@....cz> wrote:
>> > Hi!
>> >
>> >> > In current implementation this file on read returns the number
>> >> > of remaining repeat intervals. I'd add that to this description.
>> >>
>> >> I saw Pavel's comments that he did not suggest do this. So I will keep
>> >> the original description?
>> >
>> > If that is accepted, the code should return originally written number.
>>
>> But I think it is more reasonable if user can know how many
>> repetitions were left. So for your hardware case, can we add
>> pattern_get() interface back to get the repetition number?
>
> Well, I'd say that we are mostly seeing "infinite" repetitions, or one
> repetition.
>
> Yes, interface could be added to the lowlever driver -- but I'm not
> sure hardware really supports getting that information; could be
> tricky on N900 for example.
>
> I'd keep it simple for now.

OK, I also like to keep it simple. I am fine the repeat file returns
originally written number. If Jacek also agrees with this, then I will
update new version.

-- 
Baolin Wang
Best Regards