linux-kernel - Re: [PATCH 8/8] rtc: remove struct rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a121CrinzrXPZ86f=KkK9yfnVHF70MQQYt2VVr-6jCnGQ@mail.gmail.com>
Date:   Mon, 6 Aug 2018 11:06:07 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     linux-rtc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 8/8] rtc: remove struct rtc_task

On Thu, Jul 26, 2018 at 3:42 PM Alexandre Belloni
<alexandre.belloni@...tlin.com> wrote:
>
> Include rtc_task members directly in rtc_timer member.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> ---
>  drivers/rtc/interface.c | 8 ++++----
>  include/linux/rtc.h     | 9 ++-------
>  2 files changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
> index d0983ed6c842..a962540faf2e 100644
> --- a/drivers/rtc/interface.c
> +++ b/drivers/rtc/interface.c
> @@ -912,8 +912,8 @@ void rtc_timer_do_work(struct work_struct *work)
>                 timerqueue_del(&rtc->timerqueue, &timer->node);
>                 trace_rtc_timer_dequeue(timer);
>                 timer->enabled = 0;
> -               if (timer->task.func)
> -                       timer->task.func(timer->task.private_data);
> +               if (timer->func)
> +                       timer->func(timer->private_data);
>
>                 trace_rtc_timer_fired(timer);
>                 /* Re-add/fwd periodic timers */
> @@ -968,8 +968,8 @@ void rtc_timer_init(struct rtc_timer *timer, void (*f)(void *p), void *data)
>  {
>         timerqueue_init(&timer->node);
>         timer->enabled = 0;
> -       timer->task.func = f;
> -       timer->task.private_data = data;
> +       timer->func = f;
> +       timer->private_data = data;
>  }

>From what I can see, all remaining users pass the rtc_device pointer as
'private_data', so maybe make that explicit now instead of the void pointer?

      Arnd