linux-kernel - Re: [PATCH] mm/kasan/kasan_init: use true and false for boolean values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0413df4d-262d-fee8-f1a3-99ccf1d3a441@embeddedor.com>
Date:   Mon, 6 Aug 2018 06:39:02 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Linux-MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/kasan/kasan_init: use true and false for boolean
 values

Hi Dmitry,

On 08/06/2018 04:04 AM, Dmitry Vyukov wrote:
> On Sun, Aug 5, 2018 at 12:08 AM, Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>> Return statements in functions returning bool should use true or false
>> instead of an integer value.
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Hi Gustavo,
> 
> I don't see this code in upstream tree. Is it against some other tree? Which?
> 

Yep. It's against linux-next.

Should I use [PATCH next] in the subject next time?

Thanks
--
Gustavo

> Thanks
> 
>> ---
>>  mm/kasan/kasan_init.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/kasan/kasan_init.c b/mm/kasan/kasan_init.c
>> index 7a2a2f1..c742dc5 100644
>> --- a/mm/kasan/kasan_init.c
>> +++ b/mm/kasan/kasan_init.c
>> @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd)
>>  #else
>>  static inline bool kasan_p4d_table(pgd_t pgd)
>>  {
>> -       return 0;
>> +       return false;
>>  }
>>  #endif
>>  #if CONFIG_PGTABLE_LEVELS > 3
>> @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d)
>>  #else
>>  static inline bool kasan_pud_table(p4d_t p4d)
>>  {
>> -       return 0;
>> +       return false;
>>  }
>>  #endif
>>  #if CONFIG_PGTABLE_LEVELS > 2
>> @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud)
>>  #else
>>  static inline bool kasan_pmd_table(pud_t pud)
>>  {
>> -       return 0;
>> +       return false;
>>  }
>>  #endif
>>  pte_t kasan_zero_pte[PTRS_PER_PTE] __page_aligned_bss;
>> --
>> 2.7.4