linux-kernel - Re: [PATCH v3] usb: host: xhci-plat: Iterate over parent nodes for finding quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <532f004d-8a79-e61b-e668-958c162599aa@linux.intel.com>
Date:   Mon, 6 Aug 2018 16:58:40 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>,
        mathias.nyman@...el.com, gregkh@...uxfoundation.org
Cc:     v.anuragkumar@...il.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] usb: host: xhci-plat: Iterate over parent nodes for
 finding quirks

On 06.08.2018 16:04, Anurag Kumar Vulisha wrote:
> In xhci_plat_probe() both sysdev and pdev->dev are being used
> for finding quirks. There are some drivers(like dwc3 host.c)
> which adds quirks(like usb3-lpm-capable) into pdev and the logic
> present in xhci_plat_probe() checks for quirks in either sysdev
> or pdev for finding the quirks. Because of this logic, some of
> the quirks are getting missed(usb3-lpm-capable quirk added by dwc3
> host.c driver is getting missed).This patch fixes this by iterating
> over all the available parents for finding the quirks. In this way
> all the quirks which are present in child or parent are correctly
> updated.
> 
> Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>
> ---
>   Changes in v3:
> 	1. As Mathias suggested, moved the position of reading devicetree
> 	   property "imod-interval-ns" into for loop
> 
>   Changes in v2:
> 	1. As suggested by Mathias, restoring immod_interval changes to
> 	   default
> ---

Thanks, adding to queue

-Mathias