linux-kernel - Re: [PATCH 19/20] perf annotate: Add --percent-type option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180806142625.GC16446@krava>
Date:   Mon, 6 Aug 2018 16:26:25 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Stephane Eranian <eranian@...gle.com>, kernel-team@....com
Subject: Re: [PATCH 19/20] perf annotate: Add --percent-type option

On Mon, Aug 06, 2018 at 10:49:12PM +0900, Namhyung Kim wrote:
> On Sat, Aug 04, 2018 at 03:05:20PM +0200, Jiri Olsa wrote:
> > Adding --percent-type option to set annotation percent type
> > from following choices:
> >   global-period, local-period, global-hits, local-hits
> > 
> > Examples:
> >   $ perf annotate --percent-type period-local --stdio | head -1
> >    Percent         |      Source code ... es, percent: local period)
> >   $ perf annotate --percent-type hits-local --stdio | head -1
> >    Percent         |      Source code ... es, percent: local hits)
> >   $ perf annotate --percent-type hits-global --stdio | head -1
> >    Percent         |      Source code ... es, percent: global hits)
> >   $ perf annotate --percent-type period-global --stdio | head -1
> >    Percent         |      Source code ... es, percent: global period)
> > 
> > The local/global keywords set if the percentage is computed
> > in the scope of the function (local) or the whole data (global).
> > 
> > The period/hits keywords set the base the percentage is computed
> > on - the samples period or the number of samples (hits).
> 
> What about adding "period" as an alias to "local-period" (and same for
> "hits" as well)?

I dont mind that.. will add to v2 if there are no objections

thanks,
jirka