linux-kernel - Re: [PATCH v4 3/6] regmap: Add regmap_noinc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180806143901.GP2414@sirena.org.uk>
Date:   Mon, 6 Aug 2018 15:39:01 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Stefan Popa <stefan.popa@...log.com>
Cc:     jic23@...nel.org, lars@...afoo.de, Michael.Hennerich@...log.com,
        knaack.h@....de, pmeerw@...erw.net, mark.rutland@....com,
        davem@...emloft.net, mchehab+samsung@...nel.org,
        gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        robh+dt@...nel.org, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Crestez Dan Leonard <leonard.crestez@...el.com>
Subject: Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API

On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote:

> +	if (!regmap_volatile(map, reg) || !regmap_readable(map, reg)) {
> +		ret = -EINVAL;
> +		goto out_unlock;
> +	}

I suggested having an explicit operation to check if a register supports
this mode of operation when I reviewed an earlier version, I didn't
notice a reply on that?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)