linux-kernel - Re: [PATCH 03/20] perf annotate: Get rid of annotation__scnprintf_samples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180806150712.GK7996@kernel.org>
Date:   Mon, 6 Aug 2018 12:07:12 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 03/20] perf annotate: Get rid of
 annotation__scnprintf_samples_period

Em Sat, Aug 04, 2018 at 03:05:04PM +0200, Jiri Olsa escreveu:
> We have more current function tto get the title for annotation,
> which is hists__scnprintf_title. They both have same output as
> far as the annotation's header line goes.
> 
> They differ in counting of the nr_samples, hists__scnprintf_title
> provides more accurate number based on the setup of the
> symbol_conf.filter_relative variable.
> 
> Plus it also displays any uid/thread/dso/socket filters/zooms
> if there are set any, which annotation__scnprintf_samples_period
> does not.

Thanks, tested and applied.

- Arnaldo