linux-kernel - RE: linux-4.18-rc8/tools/hv/hv_kvp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <MW2PR2101MB1113A4A2F965646EDF1FEF02A0200@MW2PR2101MB1113.namprd21.prod.outlook.com>
Date:   Mon, 6 Aug 2018 15:28:03 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     David Binderman <dcb314@...mail.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:289: dead code block ?



> -----Original Message-----
> From: David Binderman <dcb314@...mail.com>
> Sent: Monday, August 6, 2018 1:08 AM
> To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; Stephen Hemminger
> <sthemmin@...rosoft.com>; devel@...uxdriverproject.org; linux-
> kernel@...r.kernel.org
> Subject: linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:289: dead code block ?
> 
> 
> Hello there,
> 
> linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:282] -> [linux-4.18-
> rc8/tools/hv/hv_kvp_daemon.c:289]: (warning) Opposite inner 'if' condition
> leads to a dead code block.
> 
> Source code is
> 
>        for (i = 0; i < num_records; i++) {
>                 if (memcmp(key, record[i].key, key_size))
>                         continue;
>                 /*
>                  * Found a match; just move the remaining
>                  * entries up.
>                  */
>                 if (i == num_records) {

Thank you! We will fix the issue.

K. Y
> 
> Regards
> 
> David Binderman