linux-kernel - Re: [PATCH] firmware: coreboot: Let OF core populate platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPKp9ubtegG-WubpMFKuzBcUHpkZJfH3DZRJs83HHJeGCxK7qg@mail.gmail.com>
Date:   Mon, 6 Aug 2018 18:22:06 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     swboyd@...omium.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>, wnhuang@...omium.org,
        jwerner@...omium.org, briannorris@...omium.org,
        samuel@...lland.org, thierry.escande@...labora.com,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH] firmware: coreboot: Let OF core populate platform device

On Mon, Aug 6, 2018 at 6:13 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> Now that the /firmware/coreboot node in DT is populated by the core DT
> platform code with commit 3aa0582fdb82 ("of: platform: populate
> /firmware/ node from of_platform_default_populate_init()") we should and
> can remove the platform device creation here. Otherwise, the
> of_platform_device_create() call will fail, the coreboot of driver won't
> be registered, and this driver will never bind. At the same time, we can
> move this driver to use platform device APIs instead of DT specific ones
> and drop the of_node handling that was presumably placed there to hold a
> reference to the DT node created during module init.
>

Nice cleanup.

Reviewed-by: Sudeep Holla <Sudeep.Holla@....com>

--
Regards,
Sudeep