linux-kernel - Re: [PATCH] spi: orion: cosmetics - alias long direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADxo8W+5rvp-cFzqiSJ7RGC13N42v45N0pJ+m+2qO8DQ5AWS7Q@mail.gmail.com>
Date:   Mon, 6 Aug 2018 22:27:46 +0300
From:   Kosta Zertsekel <zertsekel@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jan Kundrát <jan.kundrat@...net.cz>,
        Stefan Roese <sr@...x.de>, Ken Wilson <ken.wilson@...ngear.com>
Subject: Re: [PATCH] spi: orion: cosmetics - alias long direct_access variables

On Mon, Aug 6, 2018 at 10:09 PM Andrew Lunn <andrew@...n.ch> wrote:
>> @@ -683,6 +683,7 @@ static int orion_spi_probe(struct platform_device *pdev)
>>
>>       /* Scan all SPI devices of this controller for direct mapped devices */
>>       for_each_available_child_of_node(pdev->dev.of_node, np) {
>> +             struct orion_direct_acc *dacc;
>
> I would prefer direct_access, but it looks like this is too long to
> put the devm_ioremap on one line. But it should be enough to fix the
> odd indentation of r->start and PAGE_SIZE.

Actually, the longest possible name to put devm_ioremap on one line is
`dir_acc`.
I think `dir_acc` is readable enough to ring the `direct_access` in
the mind of a reader.