linux-kernel - Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180806052949eucas1p2483800c02730febd03d4a661a25fa405~INH40XvCx2719627196eucas1p2X@eucas1p2.samsung.com>
Date:   Mon, 6 Aug 2018 07:29:48 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Ravi Chandra Sadineni <ravisadineni@...omium.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Ravi Chandra Sadineni <ravisadineni@...gle.com>,
        Dmitry Torokhov <dtor@...gle.com>,
        Todd Broch <tbroch@...gle.com>, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] Input: cros_ec_keyb: Remove check before calling
 pm_wakeup_event.

Hi Ravi,

On 2018-08-03 18:53, Ravi Chandra Sadineni wrote:
> Understood. I am trying to reproduce this issue locally. Wanted to 
> know the version of the kernel so I can give a try. Marek, can you 
> please confirm the kernel version.
>

Yes, sorry for the missing context, I was in hurry writing the report and
I wanted to send it before leaving the office. I'm testing mainline on Snow
with exynos_defconfig.

Suspend/resume is partially broken already with mainline, but if you disable
CPUfreq support, it works fine on Linux v4.17.

I've posted CPUfreq related fixes here if you are interested:
https://patchwork.kernel.org/patch/10554607/
https://patchwork.kernel.org/patch/10554603/

The issue with cros_ec_keyb patch appears first on Linux v4.18-rc1, which is
the first release with that patch. Linux -next from 20180803, which has 
a few
more patches for cros_ec_keyb suffers from the same issue.


>
> On Fri, Aug 3, 2018 at 9:08 AM Dmitry Torokhov 
> <dmitry.torokhov@...il.com <mailto:dmitry.torokhov@...il.com>> wrote:
>
>     On Fri, Aug 3, 2018 at 8:51 AM Ravi Chandra Sadineni
>     <ravisadineni@...omium.org <mailto:ravisadineni@...omium.org>> wrote:
>     >
>     > Hi Marek,
>     >
>     > Can you please give me little more context ? Snow is still on
>     3.8.11. This patch is not backported to 3.8.11. Are you trying to
>     flash a different kernel  on snow?
>     >
>
>     Ravi, from upstream perspective what kernel Google uses when shipping
>     Snow is completely immaterial. Mainline is supposed to work equally
>     well on all devices.
>
>     Thanks.
>
>     -- 
>     Dmitry
>

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland