linux-kernel - Re: [PATCH v2] spi: orion: cosmetics - alias long direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180806200640.GL9372@lunn.ch>
Date:   Mon, 6 Aug 2018 22:06:40 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Kosta Zertsekel <zertsekel@...il.com>
Cc:     Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jan Kundrát <jan.kundrat@...net.cz>,
        Stefan Roese <sr@...x.de>, Ken Wilson <ken.wilson@...ngear.com>
Subject: Re: [PATCH v2] spi: orion: cosmetics - alias long direct_access
 variables

On Mon, Aug 06, 2018 at 10:50:02PM +0300, Kosta Zertsekel wrote:
> This change increases the source code readability.
> Instead of using `spi->child[cs].direct_access.XXX` use `dacc->XXX`.

Hi Kosta

You forgot to update this line.

Please wait a week to allow others to comment, then submit a v3, and
include:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew