linux-kernel - Re: [PATCH] gpu/drm/hisilicon: Convert drm_atomic_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFqt6zbuTRTxf+dw_C-YMK_qn8cB=5xWq+b_M22dep_NEWWghw@mail.gmail.com>
Date:   Mon, 6 Aug 2018 11:36:32 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     xinliang <z.liuxinliang@...ilicon.com>
Cc:     Zou Rongrong <zourongrong@...il.com>,
        kong.kongxinwei@...ilicon.com, puck.chen@...ilicon.com,
        airlied@...ux.ie, noralf@...nnes.org,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Ajit Linux <ajitn.linux@...il.com>,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        Brajeswar Ghosh <brajeswar.linux@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH] gpu/drm/hisilicon: Convert drm_atomic_helper_suspend/resume()

On Fri, Aug 3, 2018 at 12:33 PM, xinliang <z.liuxinliang@...ilicon.com> wrote:
>
>
> On 2018/8/2 17:57, Souptick Joarder wrote:
>>
>> On Thu, Jul 26, 2018 at 1:37 PM, Souptick Joarder<jrdr.linux@...il.com>
>> wrote:
>>>
>>> >On Thu, Jul 19, 2018 at 9:34 PM, Souptick Joarder<jrdr.linux@...il.com>
>>> > wrote:
>>>>
>>>> >>convert drm_atomic_helper_suspend/resume() to use
>>>> >>drm_mode_config_helper_suspend/resume().
>>>> >>
>>>> >>Fixed one sparse warning by making hibmc_drm_interrupt
>>>> >>static.
>>>> >>
>>>> >>Signed-off-by: Souptick Joarder<jrdr.linux@...il.com>
>>>> >>Signed-off-by: Ajit Negi<ajitn.linux@...il.com>
>>>> >>---
>>>
>>> >
>>> >Any comment on this patch ?
>>
>> Any review comment for this patch ?
>
> Sorry for late reply. Looks good to me. Thanks.
> Reviewed-by: Xinliang Liu <z.liuxinliang@...ilicon.com>

Xinliang,

I will do little more clean up by removing ret variable from
suspend / resume function and post v2.

>
>