linux-kernel - [PATCH] lib/vsprintf: Do not handle %pO[^F] as %px

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180806223421.11995-1-bart.vanassche@wdc.com>
Date:   Mon,  6 Aug 2018 15:34:21 -0700
From:   Bart Van Assche <bart.vanassche@....com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     linux-kernel@...r.kernel.org,
        Bart Van Assche <bart.vanassche@....com>,
        Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        Joe Perches <joe@...ches.com>, Rob Herring <robh@...nel.org>
Subject: [PATCH] lib/vsprintf: Do not handle %pO[^F] as %px

This patch avoids that gcc reports the following when building with W=1:

lib/vsprintf.c:1941:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   switch (fmt[1]) {
   ^~~~~~

Fixes: ce4fecf1fe15 ("vsprintf: Add %p extension "%pOF" for device tree")
Signed-off-by: Bart Van Assche <bart.vanassche@....com>
Cc: Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Cc: Joe Perches <joe@...ches.com>
Cc: Rob Herring <robh@...nel.org>
---
 lib/vsprintf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index a48aaa79d352..cda186230287 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1942,6 +1942,7 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
 		case 'F':
 			return device_node_string(buf, end, ptr, spec, fmt + 1);
 		}
+		break;
 	case 'x':
 		return pointer_string(buf, end, ptr, spec);
 	}
-- 
2.18.0