linux-kernel - Re: [RFC PATCH v2 1/2] interconnect: qcom: Add sdm845 interconnect provider driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180806225252.GQ30024@minitux>
Date:   Mon, 6 Aug 2018 15:52:52 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     David Dai <daidavid1@...eaurora.org>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        georgi.djakov@...aro.org, vincent.guittot@...aro.org,
        amit.kucheria@...aro.org, ilina@...eaurora.org,
        seansw@....qualcomm.com, grahamr@....qualcomm.com
Subject: Re: [RFC PATCH v2 1/2] interconnect: qcom: Add sdm845 interconnect
 provider driver

On Wed 18 Jul 19:36 PDT 2018, David Dai wrote:
> diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
[..]
> +DEFINE_QNODE(ipa_core_master, MASTER_IPA_CORE, 1, 8, 1, SLAVE_IPA_CORE);
[..]
> +DEFINE_QNODE(ipa_core_slave, SLAVE_IPA_CORE, 1, 8, 0);

As discussed before; while the two sides of IPA_CORE are controlled
through the "bus mechanism", they do represent the clock of the IPA
block.

I think it would make sense to make this interconnect provider also
register a clock provider and expose this as a clock, for the IPA driver
to consume.

Regards,
Bjorn