linux-kernel - Re: [PATCH v2 2/2] i2c: npcm7xx: add i2c controller master mode only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a50932025929d1b318cb42c05a727892603d31d.camel@linux.intel.com>
Date:   Tue, 07 Aug 2018 14:26:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Tali Perry <tali.perry1@...il.com>, avifishman70@...il.com,
        tmaimon77@...il.com, venture@...gle.com, yuenn@...gle.com,
        brendanhiggins@...gle.com, robh+dt@...nel.org,
        mark.rutland@....com, davem@...emloft.net,
        mchehab+samsung@...nel.org, gregkh@...uxfoundation.org,
        akpm@...ux-foundation.org, arnd@...db.de, wsa@...-dreams.de,
        pierre-yves.mordret@...com, cedric.madianga@...il.com,
        baolin.wang@...eadtrum.com, jarkko.nikula@...ux.intel.com,
        hdegoede@...hat.com, rmk+kernel@...linux.org.uk,
        ard.biesheuvel@...aro.org, thor.thayer@...ux.intel.com,
        geert@...ux-m68k.org, heikki.krogerus@...ux.intel.com,
        tglx@...utronix.de
Cc:     linux-i2c@...r.kernel.org, openbmc@...ts.ozlabs.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: npcm7xx: add i2c controller master mode only

On Tue, 2018-08-07 at 14:07 +0300, Tali Perry wrote:
> Nuvoton NPCM7XX I2C Controller
> NPCM7xx includes 16 I2C contollers. THis driver operates the
> controller.
> This module also includes a slave mode, which will be submitted later
> on.
> 
> Any feedback would be appreciated.  
> 
> v2 -> v1:
> 	- run check patch in strict mode.
> 	- use linux crc.
> 	- define regs in constant offset without base.
> 	- remove debug prints.
> 	- no declerations for local functions.
> 	
> v1: initial version

I don't know / remember why I'm in Cc list here, but you can go through
my other reviews and find style recommendations for your code as well.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy