linux-kernel - semantic conflict between tip and kvm (was Re: linux-next: Signed-off-by missing for commit in the kvm tree)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8939315c-f509-ad12-3484-4650c7f3b351@redhat.com>
Date:   Tue, 7 Aug 2018 15:09:25 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Radim Krčmář <rkrcmar@...hat.com>,
        KVM <kvm@...r.kernel.org>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: semantic conflict between tip and kvm (was Re: linux-next:
 Signed-off-by missing for commit in the kvm tree)

On 06/08/2018 23:39, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   81781b6884bd ("KVM/x86: Use CC_SET()/CC_OUT in arch/x86/kvm/vmx.c")
> 
> is missing a Signed-off-by from its committer.
> 

Stephen,

there is a semantic conflict between tip and kvm:

const __initconst struct hypervisor_x86 x86_hyper_kvm = {
	.name			= "KVM",
	.detect			= kvm_detect,
	.type			= X86_HYPER_KVM,
	.init.init_platform	= kvmclock_init,
	.init.guest_late_init	= kvm_guest_init,
	.init.x2apic_available	= kvm_para_available,
	.init.init_platform	= kvm_init_platform,
};

Note that .init.init_platform is initialized twice.

The right fix is to keep the kvm version, and add a kvmclock_init() call
to kvm_init_platform.

Thanks,

Paolo



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)