linux-kernel - Re: [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180807165502.GD160295@google.com>
Date:   Tue, 7 Aug 2018 09:55:02 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Guenter Roeck <groeck@...gle.com>
Cc:     bardliao@...ltek.com, oder_chiou@...ltek.com,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Nicolas Boichat <drinkcat@...omium.org>
Subject: Re: [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match

On Tue, Aug 07, 2018 at 09:39:38AM -0700, Guenter Roeck wrote:
> On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke <mka@...omium.org> wrote:
> >
> > The initializer of rt5677_of_match contains a bogus device id
> > (enum type) for the 'type' field (char []). Remove it.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> > ---
> >  sound/soc/codecs/rt5677.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> > index 8a0181a2db08..7dab53b35cbf 100644
> > --- a/sound/soc/codecs/rt5677.c
> > +++ b/sound/soc/codecs/rt5677.c
> > @@ -5007,7 +5007,7 @@ static const struct regmap_config rt5677_regmap = {
> >  };
> >
> >  static const struct of_device_id rt5677_of_match[] = {
> > -       { .compatible = "realtek,rt5677", RT5677 },
> > +       { .compatible = "realtek,rt5677", },
> 
> Is that indeed not used, or should it be the following ?
>                         ...  , .data = RT5677 },

You are right, I missed that the driver uses of_device_id->data, will
update.

Thanks!

Matthias