linux-kernel - Re: [PATCH v2] ASoC: rt5677: Fix initialization of rt5677_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180807202306.GE160295@google.com>
Date:   Tue, 7 Aug 2018 13:23:06 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Guenter Roeck <groeck@...omium.org>,
        Nicolas Boichat <drinkcat@...omium.org>
Subject: Re: [PATCH v2] ASoC: rt5677: Fix initialization of
 rt5677_of_match.data

On Tue, Aug 07, 2018 at 10:13:47PM +0300, Andy Shevchenko wrote:
> On Tue, 2018-08-07 at 10:19 -0700, Matthias Kaehlcke wrote:
> > The driver expects to find the device id in rt5677_of_match.data,
> > however
> > it is currently assigned to rt5677_of_match.type. Fix this.
> > 
> > The problem was found with the help of clang:
> >   sound/soc/codecs/rt5677.c:5010:36: warning: expression which
> > evaluates to
> >   zero treated as a null pointer constant of type 'const void *'
> >   [-Wnon-literal-null-conversion]
> >     { .compatible = "realtek,rt5677", RT5677 },
> >                                       ^~~~~~
> > 
> > Fixes: ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module
> > sources")
> > Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> 
> While this is correct fix, it seems it was never used.

Or it was used but no problem was noticed because .data was already
0, which happens to be the value of RT5677.

> Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks

Matthias