linux-kernel - Re: [PATCH] phy: qcom-qmp: Fix dts bindings to reflect reality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=We9OQggYh_vpB6AF4uj=Fk1cqVZZhOijfOv0fEh98DZw@mail.gmail.com>
Date:   Mon, 6 Aug 2018 22:18:03 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        Manu Gautam <mgautam@...eaurora.org>,
        Varadarajan Narayanan <varada@...eaurora.org>
Subject: Re: [PATCH] phy: qcom-qmp: Fix dts bindings to reflect reality

Hi,

On Mon, Jul 23, 2018 at 4:33 PM, Rob Herring <robh@...nel.org> wrote:
>> OK, I guess I will try again then and you can tell me when I get it
>> right (unless you tell me I should just change the driver to not use
>> named registers at all).  How about:
>>
>> - reg:
>>   - For "qcom,sdm845-qmp-usb3-phy":
>>     - index 0: address and length of register set for PHY's common serdes
>>                block.
>>     - index 1: address and length of the DP_COM control block.
>
> Instead of repeating index 0 below, just say "for
> 'qcom,sdm845-qmp-usb3-phy' only" here.
>
>>   - For all others:
>>     - index 0: address and length of register set for PHY's common serdes
>>                block.
>> - reg-names:
>>   - For "qcom,sdm845-qmp-usb3-phy":
>>     - Should be: "reg-base", "dp_com"
>>   - For all others:
>>     - The reg-names property shouldn't be defined.

To close the loop, I've just posted
<https://lore.kernel.org/patchwork/patch/972177/> AKA ("dt-bindings:
phy: qcom-qmp: Cleanup the 'reg' documentation as per review").
Hopefully that addresses everything properly but if not I'm happy to
spin it again.  Thanks for your patience in helping me understand what
you were looking for.

-Doug