lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Aug 2018 13:28:19 +0800 From: Huang Rui <ray.huang@....com> To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Felix Kuehling <felix.kuehling@....com> CC: Oded Gabbay <oded.gabbay@...il.com>, Alex Deucher <alexander.deucher@....com>, Christian K�nig <christian.koenig@....com>, "David (ChunMing) Zhou" <David1.Zhou@....com>, David Airlie <airlied@...ux.ie>, <amd-gfx@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drm/amdkfd: Use true and false for boolean values On Sat, Aug 04, 2018 at 07:27:02PM -0500, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use true or false > instead of an integer value. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> Looks good for me. Reviewed-by: Huang Rui <ray.huang@....com> Add Felix for his awareness. > --- > drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c > index 5d2475d..16af9d1 100644 > --- a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c > +++ b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c > @@ -62,12 +62,12 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev, > vmid = (ihre->ring_id & 0x0000ff00) >> 8; > if (vmid < dev->vm_info.first_vmid_kfd || > vmid > dev->vm_info.last_vmid_kfd) > - return 0; > + return false; > > /* If there is no valid PASID, it's likely a firmware bug */ > pasid = (ihre->ring_id & 0xffff0000) >> 16; > if (WARN_ONCE(pasid == 0, "FW bug: No PASID in KFD interrupt")) > - return 0; > + return false; > > /* Interrupt types we care about: various signals and faults. > * They will be forwarded to a work queue (see below). > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@...ts.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Powered by blists - more mailing lists