linux-kernel - Re: [PATCH] media: dt: adv7604: Fix slave map documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Aug 2018 09:48:00 +0200
From:   Michal Vokáč <michal.vokac@...ft.com>
To:     Kieran Bingham <kieran.bingham@...asonboard.com>,
        mchehab@...nel.org, linux-media@...r.kernel.org
Cc:     linux-renesas-soc@...r.kernel.org,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dt: adv7604: Fix slave map documentation

On 7.8.2018 17:54, Kieran Bingham wrote:
Hi Kieran,
> The reg-names property in the documentation is missing an '='. Add it.
> 
> Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend
> bindings to allow specifying slave map addresses")
> 

"dt-bindings: media: " is preferred for the subject.

I think you should also add device tree maintainers to the recipients.

Best regards,
Michal

> Signed-off-by: Kieran Bingham <kieran.bingham@...asonboard.com>
> ---
>   Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> index dcf57e7c60eb..b3e688b77a38 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> @@ -66,7 +66,7 @@ Example:
>   		 * other maps will retain their default addresses.
>   		 */
>   		reg = <0x4c>, <0x66>;
> -		reg-names "main", "edid";
> +		reg-names = "main", "edid";
>   
>   		reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>;
>   		hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;
>