linux-kernel - Re: [PATCH 05/17] staging:rtl8192u: Rename cpMacAddr Macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 08 Aug 2018 01:14:11 -0700
From:   Joe Perches <joe@...ches.com>
To:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH 05/17] staging:rtl8192u: Rename cpMacAddr Macro - Style

On Tue, 2018-08-07 at 22:12 +0100, John Whitmore wrote:
> Rename the Macro cpMacAddr(des, src), as it causes a checkpatch issue
> due its use of CamelCase naming, to cp_mac_addr(des, src).
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
[]
> @@ -33,7 +33,7 @@ struct rt_dot11d_info {
>  #define eq_mac_addr(a, b)		(((a)[0] == (b)[0] &&		    \
>  	(a)[1] == (b)[1] && (a)[2] == (b)[2] && (a)[3] == (b)[3] && \
>  	(a)[4] == (b)[4] && (a)[5] == (b)[5]) ? 1 : 0)
> -#define cpMacAddr(des, src)	      ((des)[0] = (src)[0], \
> +#define cp_mac_addr(des, src)	      ((des)[0] = (src)[0], \
>  	(des)[1] = (src)[1], (des)[2] = (src)[2], \
>  	(des)[3] = (src)[3], (des)[4] = (src)[4], \
>  	(des)[5] = (src)[5])

And this could be ether_addr_copy