linux-kernel - Re: [PATCH 04/15] staging: gasket: core: convert remaining info logs to debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Aug 2018 11:17:57 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Todd Poynor <toddpoynor@...il.com>
Cc:     Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>,
        Ben Chan <benchan@...omium.org>, devel@...verdev.osuosl.org,
        Todd Poynor <toddpoynor@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/15] staging: gasket: core: convert remaining info logs
 to debug

On Sun, Aug 05, 2018 at 01:07:38PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@...gle.com>
> 
> Remaining info-level logs in gasket core converted to debug-level; the
> information is not needed during normal system operation.
> 
> Signed-off-by: Todd Poynor <toddpoynor@...gle.com>
> ---
>  drivers/staging/gasket/gasket_core.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
> index 01cafe1ff6605..2741256eacfe8 100644
> --- a/drivers/staging/gasket/gasket_core.c
> +++ b/drivers/staging/gasket/gasket_core.c
> @@ -1819,7 +1819,7 @@ void gasket_unregister_device(const struct gasket_driver_desc *driver_desc)
>  	g_descs[desc_idx].driver_desc = NULL;
>  	mutex_unlock(&g_mutex);
>  
> -	pr_info("removed %s driver\n", driver_desc->name);
> +	pr_debug("removed %s driver\n", driver_desc->name);
>  }
>  EXPORT_SYMBOL(gasket_unregister_device);
>  
> @@ -1827,7 +1827,7 @@ static int __init gasket_init(void)
>  {
>  	int i;
>  
> -	pr_info("Performing one-time init of the Gasket framework.\n");
> +	pr_debug("%s\n", __func__);

Lines like this should just be deleted, that is what ftrace is for :)

>  	/* Check for duplicates and find a free slot. */
>  	mutex_lock(&g_mutex);
>  	for (i = 0; i < GASKET_FRAMEWORK_DESC_MAX; i++) {
> @@ -1843,8 +1843,7 @@ static int __init gasket_init(void)
>  
>  static void __exit gasket_exit(void)
>  {
> -	/* No deinit/dealloc needed at present. */
> -	pr_info("Removing Gasket framework module.\n");
> +	pr_debug("%s\n", __func__);

No need to have an exit function at all, right?

I'll take this for now, as this is the last day for me to take patches
for 4.19-rc1, but keep this in mind for the future.

thanks,

greg k-h