linux-kernel - Re: [PATCH] media: dt: adv7604: Fix slave map documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 08 Aug 2018 13:25:53 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     kieran.bingham@...asonboard.com
Cc:     Michal Vokáč <michal.vokac@...ft.com>,
        mchehab@...nel.org, linux-media@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-renesas-soc@...r.kernel.org,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dt: adv7604: Fix slave map documentation

Hi Kieran,

On Wednesday, 8 August 2018 13:23:32 EEST Kieran Bingham wrote:
> Hi Michal,
> 
> Thank you for your review.
> 
> +Rob, +Mark, +Laurent asking for opinions if anyone has any on prefixes
> through media tree.
> 
> On 08/08/18 08:48, Michal Vokáč wrote:
> > On 7.8.2018 17:54, Kieran Bingham wrote:
> > Hi Kieran,
> > 
> >> The reg-names property in the documentation is missing an '='. Add it.
> >> 
> >> Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend
> >> bindings to allow specifying slave map addresses")
> > 
> > "dt-bindings: media: " is preferred for the subject.
> 
> This patch will go through the media-tree as far as I am aware, and
> Mauro prefixes all commits through the media tree with "media:" if they
> are not already prefixed.
> 
> Thus this would then become "media: dt-bindings: media: adv7604: ...."
> as per my commit: 9feb786876c7 which seems a bit redundant.
> 
> Is it still desired ? If so I'll send a V2. (perhaps needed anyway, as I
> seem to have erroneously shortened dt-bindings: to just dt: which wasn't
> intentional.
> 
> > I think you should also add device tree maintainers to the recipients.
> 
> Added to this mail to ask opinions on patch prefixes above.
> 
> Originally, I believed the list was sufficient as this is a trivial
> patch, and it goes through the media tree.
> 
> But, it turned out to be more controversial :)
> 
> Rob, Mark, should I add you to all patches affecting DT? Or is the list
> sufficient?

Given the insane amount of patches received by DT maintainers, I personally 
try to use common sense and only disturb them when needed. Such a typo fix 
doesn't qualify for a full CC list in my opinion.

> >> Signed-off-by: Kieran Bingham <kieran.bingham@...asonboard.com>
> >> ---
> >>   Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> >> b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> >> index dcf57e7c60eb..b3e688b77a38 100644
> >> --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> >> +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> >> @@ -66,7 +66,7 @@ Example:
> >>            * other maps will retain their default addresses.
> >>            */
> >>           reg = <0x4c>, <0x66>;
> >> -        reg-names "main", "edid";
> >> +        reg-names = "main", "edid";
> >>             reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>;
> >>           hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;

-- 
Regards,

Laurent Pinchart