lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 8 Aug 2018 14:22:19 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Leonardo Brás <leobras.c@...il.com>
Cc:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/15] staging: fbtft: Fixes some defines styles -
 Style

On Tue, Aug 07, 2018 at 09:29:25PM -0300, Leonardo Brás wrote:
> Fixing some styles as recommended by checkpatch.pl.
> 
> Signed-off-by: Leonardo Brás <leobras.c@...il.com>
> ---
>  drivers/staging/fbtft/fbtft-bus.c  | 10 ++++++----
>  drivers/staging/fbtft/fbtft-core.c |  6 ++++--
>  drivers/staging/fbtft/fbtft.h      |  4 ++--
>  3 files changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 8ce1ff9b6c2a..20d94712cc84 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -60,11 +60,13 @@ void func(struct fbtft_par *par, int len, ...)                                \
>  out:									      \
>  	va_end(args);                                                         \
>  }                                                                             \
> -EXPORT_SYMBOL(func);
> +EXPORT_SYMBOL(func)

why did you change this line?

>  
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> -define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +#define no_modf /*No modifier*/

Ick ick ick, no.

> +
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, no_modf);
> +define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16);
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, no_modf);



>  
>  void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
>  {
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index 64f69d1a3029..8b79353c722a 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -275,6 +275,7 @@ void fbtft_unregister_backlight(struct fbtft_par *par)
>  		par->info->bl_dev = NULL;
>  	}
>  }
> +EXPORT_SYMBOL(fbtft_unregister_backlight);

You are doing a lot of different things all in one patch, please break
this up into one patch per logical thing.

thanks,

greg k-h

Powered by blists - more mailing lists