lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 8 Aug 2018 08:53:01 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Liu, Changcheng" <changcheng.liu@...el.com>
Cc:     broonie@...nsource.wolfsonmicro.com, mingo@...hat.com,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] ASoC: trace: track dapm type in snd_soc_dapm_widget

On Wed, 8 Aug 2018 20:39:22 +0800
"Liu, Changcheng" <changcheng.liu@...el.com> wrote:

> > > -	TP_printk("widget=%s val=%d", __get_str(name),
> > > -		  (int)__entry->val)
> > > +	TP_printk("widget=%s dapm_id=%d val=%d", __get_str(name),
> > > +		  (int)__entry->id, (int)__entry->val)  
> > 
> > Not sure why it was there before, but the (int) typecast isn't needed
> > in either case. __field(int, val) makes __entry->val of type int. Same
> > for id.
> > 
> > -- Steve  
> 
> @Steve: This patch aims at tracking the dapm up/down sequence. For the
> (int) typecast format problem, what do you think of using another
> seperate patch to resolve it?

Yeah, I was just commenting on that as a general comment. It doesn't
affect the actual patch, which I don't see anything wrong with it from
a tracing point of view.

I agree the typecast removal should be done in a separate clean-up
patch.

-- Steve

Powered by blists - more mailing lists