linux-kernel - Re: [PATCH] clocksource: ti-32k: Add CLOCK_SOURCE_SUSPEND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Aug 2018 18:40:50 +0530
From:   "J, KEERTHY" <j-keerthy@...com>
To:     Tony Lindgren <tony@...mide.com>
CC:     <daniel.lezcano@...aro.org>, <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <baolin.wang@...aro.org>, <d-gerlach@...com>,
        <grygorii.strashko@...com>, <t-kristo@...com>,
        Lokesh Vutla <lokeshvutla@...com>
Subject: Re: [PATCH] clocksource: ti-32k: Add CLOCK_SOURCE_SUSPEND_NONSTOP
 flag for non-am43 SoCs



On 8/8/2018 12:28 PM, Tony Lindgren wrote:
> * Keerthy <j-keerthy@...com> [180807 09:29]:
>> The 32k clocksource is NONSTOP for non-am43 SoCs. Hence
>> add the flag for all the other SoCs.
>>
>> Reported-by: Tony Lindgren <tony@...mide.com>
>> Signed-off-by: Keerthy <j-keerthy@...com>
> 
> Acked-by: Tony Lindgren <tony@...mide.com>

Thanks Tony. Lokesh pointed out about am43x-epos. So will make a minor 
correction to this patch with compatible. I searched all the am4 boards 
& seems like ti,am43 is the most generic compatible cover am43x-epos as 
well. So i will retain your ack and send a v2 with am43 compatible 
changed to a more generic ti,am43.

> 
>> ---
>>   drivers/clocksource/timer-ti-32k.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
>> index 29e2e1a..dd09171 100644
>> --- a/drivers/clocksource/timer-ti-32k.c
>> +++ b/drivers/clocksource/timer-ti-32k.c
>> @@ -97,6 +97,9 @@ static int __init ti_32k_timer_init(struct device_node *np)
>>   		return -ENXIO;
>>   	}
>>   
>> +	if (!of_machine_is_compatible("ti,am4372"))
>> +		ti_32k_timer.cs.flags |= CLOCK_SOURCE_SUSPEND_NONSTOP;
>> +
>>   	ti_32k_timer.counter = ti_32k_timer.base;
>>   
>>   	/*
>> -- 
>> 1.9.1
>>