linux-kernel - Re: [PATCH v2 01/15] staging:rtl8192u: Remove macro eqMacAddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 08 Aug 2018 15:14:19 -0700
From:   Joe Perches <joe@...ches.com>
To:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH v2 01/15] staging:rtl8192u: Remove macro eqMacAddr -
 Style

On Wed, 2018-08-08 at 22:00 +0100, John Whitmore wrote:
> The macro eqMacAddr implements the same functionality as the
> ether_addr_equal function defined in etherdevice.h, as a result the
> macro has been removed from the code, and its use replaced with the
> function call.
[]
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
[]
> @@ -4460,15 +4460,15 @@ static void TranslateRxSignalStuff819xUsb(struct sk_buff *skb,
>  
>  	/* Check if the received packet is acceptable. */
>  	bpacket_match_bssid = (type != IEEE80211_FTYPE_CTL) &&
> -			       (eqMacAddr(priv->ieee80211->current_network.bssid,  (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 : (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 : hdr->addr3))
> +			       (ether_addr_equal(priv->ieee80211->current_network.bssid,  (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 : (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 : hdr->addr3))
>  			       && (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV);
>  	bpacket_toself =  bpacket_match_bssid &
> -			  (eqMacAddr(praddr, priv->ieee80211->dev->dev_addr));
> +			  (ether_addr_equal(praddr, priv->ieee80211->dev->dev_addr));

Likely this should be

	bpacket_match_bssid = bpacket_match_bss &&

as boolean use with a bitwise & is odd.