linux-kernel - RE: [External] Re: [PATCH] ACPI: nfit: check dcr immediately following its assignment codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYAPR03MB31812802CA589A9018B58E5789250@TYAPR03MB3181.apcprd03.prod.outlook.com>
Date:   Thu, 9 Aug 2018 01:35:53 +0000
From:   Ocean HY1 He <hehy1@...ovo.com>
To:     "Verma, Vishal L" <vishal.l.verma@...el.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "ross.zwisler@...ux.intel.com" <ross.zwisler@...ux.intel.com>,
        "oceanhehy@...il.com" <oceanhehy@...il.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: RE: [External]  Re: [PATCH] ACPI: nfit: check dcr immediately
 following its assignment codes



> -----Original Message-----
> From: Verma, Vishal L <vishal.l.verma@...el.com>
> Sent: Thursday, August 09, 2018 1:43 AM
> To: Williams, Dan J <dan.j.williams@...el.com>; ross.zwisler@...ux.intel.com;
> oceanhehy@...il.com; Jiang, Dave <dave.jiang@...el.com>; lenb@...nel.org;
> rjw@...ysocki.net
> Cc: linux-kernel@...r.kernel.org; linux-nvdimm@...ts.01.org; linux-
> acpi@...r.kernel.org; Ocean HY1 He <hehy1@...ovo.com>
> Subject: [External] Re: [PATCH] ACPI: nfit: check dcr immediately following its
> assignment codes
> 
> 
> On Wed, 2018-08-08 at 10:50 -0400, Ocean He wrote:
> > From: Ocean He <hehy1@...ovo.com>
> >
> > In commit 6697b2cf69d43632 ("nfit: fix multi-interface dimm handling,
> > acpi6.1 compatibility"), the check codes of dcr were just following its
> > assignment codes. But they were separated by commit ad9ac5e1957531a8
> > ("nfit: always associate flush hints").
> >
> > Just change the check codes back to original position, without function
> > change.
> >
> > Signed-off-by: Ocean He <hehy1@...ovo.com>
> > ---
> >  drivers/acpi/nfit/core.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> This seems like unnecessary churn. Does it cause any problems in
> practice?
> 
The original codes do not cause any problems.
Ocean.
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index 7c47900..c9e4c9a 100644
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -1078,6 +1078,12 @@ static int __nfit_mem_init(struct acpi_nfit_desc
> *acpi_desc,
> >  			break;
> >  		}
> >
> > +		if (dcr && !nfit_mem->dcr) {
> > +			dev_err(acpi_desc->dev, "SPA %d missing DCR %d\n",
> > +					spa->range_index, dcr);
> > +			return -ENODEV;
> > +		}
> > +
> >  		list_for_each_entry(nfit_flush, &acpi_desc->flushes, list) {
> >  			struct acpi_nfit_flush_address *flush;
> >  			u16 i;
> > @@ -1101,12 +1107,6 @@ static int __nfit_mem_init(struct acpi_nfit_desc
> *acpi_desc,
> >  			break;
> >  		}
> >
> > -		if (dcr && !nfit_mem->dcr) {
> > -			dev_err(acpi_desc->dev, "SPA %d missing DCR %d\n",
> > -					spa->range_index, dcr);
> > -			return -ENODEV;
> > -		}
> > -
> >  		if (type == NFIT_SPA_DCR) {
> >  			struct nfit_idt *nfit_idt;
> >  			u16 idt_idx;