linux-kernel - Re: [alsa-devel] [PATCH] ASoC: adau1761: Mark expected switch fall-though

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4934d9ae-96df-288b-2a7c-76aaa89246fe@metafoo.de>
Date:   Thu, 9 Aug 2018 13:19:11 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Mark Brown <broonie@...nel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, Takashi Iwai <tiwai@...e.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: adau1761: Mark expected switch
 fall-though

On 08/09/2018 11:31 AM, Mark Brown wrote:
> On Wed, Aug 08, 2018 at 02:22:13PM -0500, Gustavo A. R. Silva wrote:
> 
>> @@ -518,7 +518,8 @@ static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component)
>>  			ARRAY_SIZE(adau1761_jack_detect_controls));
>>  		if (ret)
>>  			return ret;
>> -	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: /* fallthrough */
>> +		/* fall through */
>> +	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE:
>>  		ret = snd_soc_dapm_add_routes(dapm, adau1761_no_dmic_routes,
>>  			ARRAY_SIZE(adau1761_no_dmic_routes));
>>  		if (ret)
> 
> Again, are you *sure* here?

Well, it says so in the comment next to it :)

Acked-by: Lars-Peter Clausen <lars@...afoo.de>