linux-kernel - Re: [PATCH] ftrace: remove unused pointer ftrace_swapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Aug 2018 10:18:42 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Ingo Molnar <mingo@...hat.com>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ftrace: remove unused pointer ftrace_swapper_pid

On Thu,  9 Aug 2018 13:56:09 +0100
Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer ftrace_swapper_pid is defined but is never used hence it is
> redundant and can be removed. The use of this variable was removed
> in commit 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap
> like events do").
> 
> Cleans up clang warning:
> warning: 'ftrace_swapper_pid' defined but not used [-Wunused-const-variable=]

Thanks, applied!

-- Steve

> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  kernel/trace/ftrace.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index caf9cbf35816..2cc008cfbd4f 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -1049,8 +1049,6 @@ static __init void ftrace_profile_tracefs(struct dentry *d_tracer)
>  }
>  #endif /* CONFIG_FUNCTION_PROFILER */
>  
> -static struct pid * const ftrace_swapper_pid = &init_struct_pid;
> -
>  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>  static int ftrace_graph_active;
>  #else