linux-kernel - Re: [PATCH v1 2/3] dt-bindings: i3c: Document Qualcomm GENI I3C master bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153382720283.220756.3098223794140406023@swboyd.mtv.corp.google.com>
Date:   Thu, 09 Aug 2018 08:06:42 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Mike Shettel <mshettel@...eaurora.org>,
        boris.brezillon@...tlin.com, devicetree@...r.kernel.org,
        gregkh@...uxfoundation.org, mark.rutland@....com,
        robh+dt@...nel.org
Cc:     Mike Shettel <mshettel@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, evgreen@...omium.org,
        acourbot@...omium.org, dianders@...omium.org, mka@...omium.org,
        bjorn.andersson@...aro.org
Subject: Re: [PATCH v1 2/3] dt-bindings: i3c: Document Qualcomm GENI I3C master
 bindings

Quoting Mike Shettel (2018-07-31 22:39:01)
> Signed-off-by: Mike Shettel <mshettel@...eaurora.org>

You need to write some commit text here. Otherwise we don't know why we
want to even look at the patch.

> diff --git a/Documentation/devicetree/bindings/i3c/qcom,geni-i3c.txt b/Documentation/devicetree/bindings/i3c/qcom,geni-i3c.txt
> new file mode 100644
> index 0000000..8b76fda
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/qcom,geni-i3c.txt
> @@ -0,0 +1,44 @@
[...]
> +
> +I3C device connected on the bus follow the generic description (see
> +Documentation/devicetree/bindings/i3c/i3c.txt for more details).
> +
> +Example:
> +
> +       i3c-master@...40000 {

Drop leading 0 on unit addresses.