linux-kernel - Re: [PATCH v2] i2c: xlp9xx: Fix case where SSIF read transaction completes early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180809154251.twazp6scrs57sih5@ninjato>
Date:   Thu, 9 Aug 2018 17:42:52 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     George Cherian <george.cherian@...ium.com>
Cc:     linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        jglauber@...ium.com
Subject: Re: [PATCH v2] i2c: xlp9xx: Fix case where SSIF read transaction
 completes early

On Thu, Aug 09, 2018 at 05:39:59PM +0200, Wolfram Sang wrote:
> On Wed, Aug 08, 2018 at 11:36:48PM -0700, George Cherian wrote:
> > During ipmi stress tests we see occasional failure of transactions
> > at the boot time. This happens in the case of a I2C_M_RECV_LEN
> > transactions, when the read transfer completes (with the initial
> > read length of 34) before the driver gets a chance to handle interrupts.
> > 
> > The current driver code expects at least 2 interrupts for I2C_M_RECV_LEN
> > transactions. The length is updated during the first interrupt, and  the
> > buffer contents are only copied during subsequent interrupts. In case of
> > just one interrupt, we will complete the transaction without copying
> > out the bytes from RX fifo.
> > 
> > Update the code to drain the RX fifo after the length update,
> > so that the transaction completes correctly in all cases.
> > 
> > Signed-off-by: George Cherian <george.cherian@...ium.com>
> 
> Applied to for-current, thanks!

...and added stable.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)