linux-kernel - Re: [PATCH] drm/panel: simple: fix -Wliteral-conversion warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOd=JdHFkbKFRCCTdb5qwk=gmbA41NngYGUYbGhVVwONP8Q@mail.gmail.com>
Date:   Thu, 9 Aug 2018 09:38:42 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     airlied@...ux.ie, Jagan Teki <jagannadh.teki@...il.com>,
        Rob Herring <robh@...nel.org>,
        Thierry Reding <treding@...dia.com>,
        dri-devel@...ts.freedesktop.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/panel: simple: fix -Wliteral-conversion warning

On Thu, Aug 9, 2018 at 3:00 AM Thierry Reding <thierry.reding@...il.com> wrote:
>
> On Fri, Jun 15, 2018 at 03:37:49PM -0700, Nick Desaulniers wrote:
> > Fixes commit 8cfe83419cdb ("drm/panel: simple: Add
> > support for KEO TX31D200VM0BAA")
> >
> > drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from
> >       'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33
> >       [-Wliteral-conversion]
> >         .vfront_porch = { 6, 21, 33.5 },
> >                         ~        ^~~~
> > drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from
> >       'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33
> >       [-Wliteral-conversion]
> >         .vback_porch = { 6, 21, 33.5 },
> >                        ~        ^~~~
> >
> > Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> > ---
> > Alternatively, should these be rounded up to 34?  I'm guessing the
> > current behaviour (truncation) is correct since that's how the patch was
> > operating.
>
> Looks like this is a duplicate of what was merged as:
>
> commit c9b6be7dc13e2f87592ee4c9812cb450dba484d5
> Author: Stefan Agner <stefan@...er.ch>
> Date:   Thu Apr 19 23:20:03 2018 +0200

Ah, cool.  I need to be better about checking maintainers' trees.

Just curious, how come a patch from April hasn't hit torvalds/linux yet?
-- 
Thanks,
~Nick Desaulniers